refactor(@angular-devkit/core): use package exports field for secondary entries#25258
Merged
clydin merged 1 commit intoangular:mainfrom May 23, 2023
Merged
Conversation
clydin
force-pushed
the
build/core-remove-legacy-secondary
branch
7 times, most recently
from
59ef1be to
9fa10ad
Compare
clydin
added
the
action: review
JoostK
reviewed
May 23, 2023
…ry entries The secondary entry point (`node`) within the `@angular-devkit/core` package is now defined by an exports entry in the main package.json file for the package. This removes the need for the additional nested package.json file in a subdirectory. The exports field also contains backward compatible entries to allow for continued deep imports into the package. These compatibility entries will, however, be removed in a future major version. Deep imported files are not considered part of the public API of the package.
clydin
force-pushed
the
build/core-remove-legacy-secondary
branch
from
9fa10ad to
f5cb7dd
Compare
alan-agius4
approved these changes
May 23, 2023
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The secondary entry point (
node) within the@angular-devkit/corepackage is now defined by an exports entry in the main package.json file for the package. This removes the need for the additional nested package.json file in a subdirectory. The exports field also contains backward compatible entries to allow for continued deep imports into the package. These compatibility entries will, however, be removed in a future major version. Deep imported files are not considered part of the public API of the package.